translationCore icon indicating copy to clipboard operation
translationCore copied to clipboard
verified publisher icon unfoldingWord

Highlighting broken with Ampersand in tNotes original quotes

Open PhotoNomad0 opened this issue 3 years ago • 1 comments

Story Explanation

User Story

Highlighting broken with Ampersand in tNotes original quotes when there is a verse span.

@abelpz found this while testing a verse range combined with an original language quote that contained an ampersand.

To see this in tCore, download the pre-release of en_ult and en_tn in es-419_lab org. Open a php project in tCore. And for tNotes select the GL of es-419_lab/en_tn. Launch tNotes and look in abstract-nouns. The highlighting is greedy:

Screenshot 2023-03-27 at 6 47 54 AM

Features / Specifications

  • [ ]
  • [ ]
  • [ ]

Definition of Done

  • [ ]
  • [ ]
  • [ ]

Additional Context

Mockups

PhotoNomad0 avatar Mar 14 '23 18:03 PhotoNomad0

@birchamp @elsylambert - The first step here is to do a refactor: https://github.com/unfoldingWord/translationCore/issues/7492. Later we can use the shared code in all the apps so we have consistent highlighting. And then we can fix this greedy highlighting behavior in all apps at the same time.

PhotoNomad0 avatar Mar 27 '23 11:03 PhotoNomad0

@elsylambert It seems this was fixed sometime ago. Is this still a problem?

PhotoNomad0 avatar Dec 16 '24 16:12 PhotoNomad0

Verified in translationCore 3.6.7 (3ccbde3). Highlighting work fine when there is ampersand in the Original quote. Screenshot 2024-12-16 at 10 10 34 PM

elsylambert avatar Dec 17 '24 03:12 elsylambert