django-unfold icon indicating copy to clipboard operation
django-unfold copied to clipboard

ArrayField and ArrayWidget Rendering problem

Open ZairMahmood opened this issue 1 year ago • 1 comments

What version of Unfold are you using?

0.40.0

What version of Django are you using?

5.1

What browser are you using?

Chrome 128

Did you checked changelog/commit history, if the bug is not already fixed?

Yes

Did you searched other issues, if the bug is not already fixed?

Yes

Did you checked documentation?

Yes

Are you able to replicate the bug in the demo site?

ArrayWidget is not used in the demo site

Repository with reproduced bug

model code:

from django.contrib.postgres.fields import ArrayField
from django.db import models

class Customer(models.Model):
    notes = ArrayField(m.TextField(), default=list, blank=True, verbose_name='Notes')

admin code:

class CustomerInline(ModelAdmin):
    model = Customer
    extra = 1
    fields = ['notes']
    formfield_overrides = {
        ArrayField: {
            "widget": ArrayWidget,
        },
    }

Describe your issue

When adding in the following items to the array field using the widget:

- Something 1
- Something 2, Something 3
- Something 4

It saves properly in the backend as: ['Something 1', 'Something 2, Something 3', 'Something 4']

but when the page reloads, it renders as:

- Something 1
- Something 2
-  Something 3
- Something 4

Notice the extra space before Something 3 also

ZairMahmood avatar Oct 23 '24 15:10 ZairMahmood

After much investigation this is what I found: The issue arises from: https://github.com/django/django/blob/main/django/contrib/postgres/forms/array.py#L38-L41 For now, I monkeypatched this in my application to just return value instead of converting it to a string and this fixed the issue.

I think we need a way to define the delimiter when using ArrayWidget. I tried a few things like SimpleArrayField(forms.CharField(), delimiter='|', widget=ArrayWidget) but it produced funky results

ZairMahmood avatar Oct 24 '24 08:10 ZairMahmood

I just tested ArrayWidget in unfold.admin.StackedInline and unfold.admin.TabularInline and it worked without any issues. For testing I used different fields like CharField with choices and TextField.

Would you mind create minimal repository where I can see this issue?

lukasvinclav avatar Nov 02 '24 11:11 lukasvinclav

Closing this issue due to inactivity.

lukasvinclav avatar Nov 17 '24 10:11 lukasvinclav