unexpected-sinon icon indicating copy to clipboard operation
unexpected-sinon copied to clipboard

Was called negation is missing in assertion signature in documentation

Open Munter opened this issue 4 years ago • 2 comments

It is possible to assets expect(mySpy, 'was not called'). But the documentation doesn't show this assertion in the left hand menu, nor does it appear in the DSL for was called, which I would expect to say was [not] called

image

The assertions are here: https://github.com/unexpectedjs/unexpected-sinon/blob/master/lib/unexpected-sinon.js#L404-L411

Munter avatar Apr 09 '21 07:04 Munter

PR welcome ;)

papandreou avatar Apr 09 '21 09:04 papandreou

I guess it's just an artifact of the assertions being defined separately. If you turn them into one that checks expect.flags.not I think it'll come out right.

papandreou avatar Apr 09 '21 09:04 papandreou