underworld2 icon indicating copy to clipboard operation
underworld2 copied to clipboard

Update CI.yml

Open julesghub opened this issue 2 years ago • 4 comments

Use scripts to build dockers linux/arm64 and linux/amd64. Removing manifest commands as that seems to be automated now.

julesghub avatar Aug 03 '22 02:08 julesghub

Don't merge yet, until we a satisfied the new dockers on dockerhub are correct.

julesghub avatar Aug 03 '22 02:08 julesghub

What do you mean? the manifest is automated now?

rbeucher avatar Aug 03 '22 03:08 rbeucher

Specifying multiple platforms in the docker-build-push action seems to do the job of the docker manifest commands that were previously there. I tested by building & pushing a test dockers image, (with multiple platforms: one arm the or amd), to docker hub and it all seemed to work correctly. See https://hub.docker.com/repository/docker/julesg/test_docker_builds

julesghub avatar Aug 03 '22 04:08 julesghub

OK something must have changed because it was not working very well last time I tried...

rbeucher avatar Aug 03 '22 06:08 rbeucher