understrap-child icon indicating copy to clipboard operation
understrap-child copied to clipboard

Remove 'underscores' scss files as a dependency

Open bacoords opened this issue 3 years ago • 3 comments

It's time to reevaluate whether we need the the /src/sass/underscores/ dependency at all. It doesn't exist in the parent theme and much of the code is duplicated in the _understrap.scss file anyway.

I suggest we delete the directory and remove @import "assets/underscores"; from /src/sass/child-theme.scss.

bacoords avatar Dec 13 '21 23:12 bacoords

I raised this assumption long time ago. It's time imo to move away from the 'based on underscores'

Also the only dependency we are using from the npm package is the skip link i think

0dp avatar Dec 14 '21 11:12 0dp

I assume we'll always keep 'based on underscores' for SEO, visibility, legacy reasons. Plus it's in the name Understrap (not that a new name would be the worst thing), but since we don't even pull these SCSS files in the parent theme, I see no reason to keep them here.

bacoords avatar Dec 14 '21 16:12 bacoords

just removed underscores SCSS files

https://github.com/understrap/understrap-child/pull/343

kirannasim avatar Feb 25 '22 19:02 kirannasim