react-native-spotlight-input icon indicating copy to clipboard operation
react-native-spotlight-input copied to clipboard

Not dismissed when app reloads (e.g. Expo)

Open ChronSyn opened this issue 7 years ago • 1 comments

Great component, but I've noticed it suffers from the same issues with most modal components in that refreshing the app doesn't dismiss this component, nor can it be closed in these situations. The result is the overlay covering the entire UI requiring completely closing of the app and reopening.

It shouldn't be an issue in production but during development, forgetting to close the input overlay can be frustrating.

Possible fix; Change it to a <View> that's position:fixed, and expands to window height and width. It may even be an option to provide this as a prop to choose between the existing modal component or to use a view based component.

I'll take a look at doing a PR for the issue over the next few days.

ChronSyn avatar Sep 14 '18 16:09 ChronSyn

I know, it's really frustrating. Unfortunately, this is related to RN I think (https://github.com/facebook/react-native/issues/17986).

I already thought about the fixed <View> but it would imply increasing API complexity: if we wanted that view to behave like a Modal (i.e. to be on top of any other view) we would need it at top-level. Thus, we would need a new component to be placed there, or a HOC to wrap the screen/parent component.

What do you think? 🤔

gaguirre avatar Sep 17 '18 17:09 gaguirre