further-review icon indicating copy to clipboard operation
further-review copied to clipboard

Adding a reaction (:+1:) vs a comment (:+1:) doesn't complete signoff

Open n8io opened this issue 8 years ago • 4 comments

image

This may not be a bug. It might just need some training on how to signoff a PR too.

n8io avatar Aug 30 '16 13:08 n8io

Yeah, I was considering this in #4, I think we should just go ahead and add it.

paultyng avatar Aug 31 '16 14:08 paultyng

They are different things in the Github API, so it has to be queried separately, thats the only reason its not working yet.

paultyng avatar Aug 31 '16 14:08 paultyng

I would not like this, as I use reactions to approve/disapprove specific changes in convo.

CKarper avatar Apr 19 '17 15:04 CKarper

@Clapper I would only use a reaction on the PR, not comments.

kjvalencik avatar Apr 19 '17 21:04 kjvalencik