further-review

further-review copied to clipboard

I updated the further-review file by removing a maintainer and adding two new people. When submitting a PR it requests approval only from the new maintainers.

ethanjcohen

Platform reviewers are often also general maintainers. Add the ability to do a single sign-off instead of all areas. For example, signing off for platform, but still allowing another general...

kjvalencik

Feature Idea: Matching changes in any file

1

# Feature Idea Matching changes in any file ## Use Case Requiring platform review to disable lint. ## Usage ```json { "glob": { "S": "**/*.*", "additions": "/eslint-disable/i" } } ```

kjvalencik

Adding a reaction (:+1:) vs a comment (:+1:) doesn't complete signoff

4

 This may not be a bug. It might just need some training on how to signoff a PR too.

n8io

Easy way to invoke testing for existing org/repo pr #

1

Something like: `npm run test-pr paultyng/further-review#3` if possible.

paultyng

Allow sign off for only major, minor, patch, changes?

paultyng

If only one person from a group is required, but someone else in that group comments. Should they also have to sign off? To reduce the case of races or...

paultyng

Probably should be optional. The limit is 10, but that would probably be enough?

paultyng

Drops required sign offs when amended commit is pushed to PR

1

Scenario: - Opened PR that required general maintainer sign off as well as glob based sign off - Received glob based sign off but not general maintainer - Pushed amended...

jeff-french

paultyng