grunt-uncss icon indicating copy to clipboard operation
grunt-uncss copied to clipboard

Published 20 hours ago • verified publisher icon uncss

Fix timing issues with file processing with multiple file sources

Open nadir-hussain opened this issue 5 years ago • 2 comments
trafficstars

Issue https://github.com/uncss/grunt-uncss/issues/227 I have added a fileInProcess counter which is incremented before calling uncss and decremented on callback called. On this flag turns to zero, I am calling the done() callback, as opposed to current code which is calling done on first file processed.

nadir-hussain avatar Oct 12 '20 05:10 nadir-hussain

Same as my 2 points in https://github.com/uncss/grunt-uncss/pull/228#issuecomment-706875756

You are creating a lot of noise. Just clone the repo and make sure your branch is green locally before pushing anything... Also, do not make unrelated changes.

XhmikosR avatar Oct 12 '20 06:10 XhmikosR

Same as my 2 points in #228 (comment)

You are creating a lot of noise. Just clone the repo and make sure your branch is green locally before pushing anything... Also, do not make unrelated changes.

Sorry, about that. I didn't have lint setup in the forked repository, I have fixed the issues now.

nadir-hussain avatar Oct 12 '20 06:10 nadir-hussain