crawl4ai
crawl4ai copied to clipboard
Feature/scraping strategy - refactor: Remove WebScrapingStrategy and fix metadata extraction (#995)
Summary
This PR refactors the content scraping strategy by removing the BeautifulSoup-based WebScrapingStrategy class and making LXMLWebScrapingStrategy the sole implementation. This simplifies the codebase by eliminating duplicate functionality while maintaining all existing features with better performance.
Additionally, this PR fixes the metadata extraction issue where titles and other metadata were returning as null for certain websites. Fixes #995
List of files changed and why
- content_scraping_strategy.py - Removed
WebScrapingStrategyclass, madeLXMLWebScrapingStrategyinherit directly fromContentScrapingStrategy, added missing methods previously inherited - async_configs.py - Updated default scraping strategy from
WebScrapingStrategy()toLXMLWebScrapingStrategy(), updated imports - types.py - Updated type definitions to remove
WebScrapingStrategyreferences - utils.py - Improve title extraction with fallbacks for edge cases
- init.py files - Updated public API exports to remove
WebScrapingStrategy - docs/examples/scraping_strategies_performance.py - Update the test and make it compatible with the new change
- tests/async/test_content_scraper_strategy.py - Update the test and make it compatible with the new change
- tests/async/test_evaluation_scraping_methods_performance.configs.py - Update the test and make it compatible with the new change
How Has This Been Tested?
- Verified that
LXMLWebScrapingStrategymaintains all functionality of the removedWebScrapingStrategy - Tested metadata extraction with problematic URLs (e.g., https://www.irs.gov/wheres-my-refund) - title and metadata now extract correctly
- Ran the existing test suite to ensure no regressions
- Tested various scraping scenarios, including:
- Image extraction and scoring
- Table detection and extraction
- Link categorization (internal/external)
- Content filtering with CSS selectors
- Media extraction with contextual descriptions
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added/updated unit tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
already merged.