enforce auth when jwt is enabled

[chrizzly2309]

Summary

If no credentials are provided, the token gets never verified, even if jwt is enabled. This PR throws a 401 exceptions then.

List of files changed and why

auth.py. Throw exception when token gets verified and no credentials provided

How Has This Been Tested?

Tested it locally

Checklist:

• [ x] My code follows the style guidelines of this project
• [ x] I have performed a self-review of my own code
• [ x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have added/updated unit tests that prove my fix is effective or that my feature works
• [x ] New and existing unit tests pass locally with my changes

Summary by CodeRabbit

• Bug Fixes
  • Improved authentication error handling by displaying an explicit error when no credentials are provided, instead of failing silently.

[coderabbitai[bot]]

Walkthrough

The verify_token function in deploy/docker/auth.py was updated to raise an HTTP 401 error with a specific message when no credentials are provided, instead of returning None. The remainder of the function, including JWT decoding and error handling for invalid or expired tokens, remains unchanged.

Changes

File(s)	Change Summary
deploy/docker/auth.py	Modified verify_token to raise HTTP 401 when credentials are missing, instead of returning None.

Poem

A hop, a skip, a check for proof,
No more silence under this roof!
If you forget your token, friend,
A 401 will swiftly send.
Rabbits guard the garden gate,
Credentials first—don’t be late!
🐇🔑

[!NOTE]

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Learn more here.

---

[!NOTE]

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings. Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 897e0173618d20fea5d8952ccdbcdad0febc0fee and 172941ed873741255ac2a09122b88c281a69a5b3.

📒 Files selected for processing (1)

• deploy/docker/auth.py (1 hunks)

🔇 Additional comments (2)

deploy/docker/auth.py (2)

34-35: Properly enforcing authentication when no credentials are provided.

This change is correct and necessary to ensure that authentication is enforced when JWT is enabled. Previously, if no credentials were provided, the token verification was bypassed by returning None. Now, a 401 Unauthorized error is properly raised, aligning with security best practices.

---

44-51:

✅ Verification successful

Verify that this change doesn't affect configurations where JWT is disabled.

The fix enforces auth when JWT is enabled, but we should ensure routes continue to work correctly when JWT authentication is disabled through configuration.

---

🏁 Script executed:

#!/bin/bash
# Check if there are any routes using the token dependency
rg "get_token_dependency" -A 5 -B 5 --type py

Length of output: 1903

---

🏁 Script executed:

#!/bin/bash
# Show token_dep assignment and subsequent route definitions in server.py
rg -n "token_dep" -A 20 deploy/docker/server.py

Length of output: 10596

---

No impact on JWT-disabled configurations
The get_token_dependency helper returns a no-op lambda when jwt_enabled=False, and although every route injects _td: Dict = Depends(token_dep), none of the handlers actually use the returned value. As a result, all endpoints continue to function normally with JWT disabled—no follow-up needed.

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.