crawl4ai icon indicating copy to clipboard operation
crawl4ai copied to clipboard

fix: Adapt to CrawlerMonitor constructor change

Open devxpain opened this issue 9 months ago • 1 comments

The upstream commit 1630fbdafe7d5c081b44bf50641f053cdf83d767 (2025-03-12) introduced a new TerminalUI and modified the CrawlerMonitor.

This change updates the codebase to align with the new CrawlerMonitor constructor interface, which no longer requires the max_visible_rows and display_mode parameters.

Summary

Fix the error below

$ uv run docs/examples/dispatcher_example.py
Traceback (most recent call last):
  File "/Volumes/Data/workspace/github/devxpain-fork/crawl4ai/docs/examples/dispatcher_example.py", line 136, in <module>
    asyncio.run(main())
  File "/Users/paynechu/.local/share/uv/python/cpython-3.10.17-macos-aarch64-none/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/Users/paynechu/.local/share/uv/python/cpython-3.10.17-macos-aarch64-none/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/Volumes/Data/workspace/github/devxpain-fork/crawl4ai/docs/examples/dispatcher_example.py", line 120, in main
    "Memory Adaptive": await memory_adaptive(urls, browser_config, run_config),
  File "/Volumes/Data/workspace/github/devxpain-fork/crawl4ai/docs/examples/dispatcher_example.py", line 26, in memory_adaptive
    monitor=CrawlerMonitor(
TypeError: CrawlerMonitor.__init__() got an unexpected keyword argument 'max_visible_rows'

How Has This Been Tested?

$ uv run docs/examples/dispatcher_example.py

Summary by CodeRabbit

  • Documentation

    • Simplified code examples and documentation by initializing monitors with default settings, removing explicit configuration parameters from all relevant examples and usage guides.
  • Tests

    • Updated tests to use default monitor initialization, removing detailed display and row limit settings from monitor instances.

devxpain avatar May 13 '25 10:05 devxpain

Walkthrough

The changes simplify the instantiation of the CrawlerMonitor and related monitor classes across documentation, examples, and tests by removing explicit configuration parameters and using their default constructors. No functional logic, error handling, or control flow is altered; only the monitor initialization is streamlined throughout the codebase.

Changes

File(s) Change Summary
docs/examples/dispatcher_example.py, docs/examples/proxy_rotation_demo.py Removed explicit parameters from CrawlerMonitor instantiations; now uses default constructor in all examples.
docs/md_v2/advanced/multi-url-crawling.md, deploy/docker/c4ai-doc-context.md Updated documentation examples to instantiate CrawlerMonitor with default settings, removing custom arguments.
deploy/docker/c4ai-code-context.md Documentation updated to use CrawlerMonitor() with default settings in dispatcher usage examples.
tests/async/test_dispatchers.py Test now creates CrawlerMonitor without arguments; previously set custom parameters.
tests/memory/test_dispatcher_stress.py StressTestMonitor instantiation simplified by removing display-related arguments.

Poem

A monitor once dressed in detail and rows,
Now hops along simply, wherever it goes.
No more display modes or numbers to show—
Just default attire, ready to flow!
With lighter examples and tests in the sun,
The codebase is simpler, and that’s a job well done.
🐇✨

[!TIP]

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 13 '25 10:05 coderabbitai[bot]