crawl4ai icon indicating copy to clipboard operation
crawl4ai copied to clipboard

fix(docker-api): migrate to modern datetime library API

Open emmanuel-ferdman opened this issue 6 months ago β€’ 3 comments

Summary

This small PR resolves the datetime library warnings:

DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). or datetime.datetime.utcnow()

Note that .replace(tzinfo=None) allows to keep the original behavior where the time appears as a naive UTC timestamp (i.e., without any timezone offset).

List of files changed and why

deploy/docker/api.py - uses datetime.utcnow().

How Has This Been Tested?

Test.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added/updated unit tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Bug Fixes
    • Improved accuracy of timestamps for job creation times.

emmanuel-ferdman avatar May 13 '25 07:05 emmanuel-ferdman

Walkthrough

The change updates the way UTC timestamps are generated for the "created_at" field in the Redis task hash within the handle_crawl_job function. The code now uses datetime.now(timezone.utc).replace(tzinfo=None).isoformat() instead of datetime.utcnow().isoformat() for timestamp creation.

Changes

Cohort / File(s) Change Summary
Timestamp Handling
deploy/docker/api.py
Modified import statement to include timezone. Updated UTC timestamp generation method in the handle_crawl_job function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

In the warren, time ticks on,
UTC now, the old way gone.
With timezone magic, bunnies cheer,
For timestamps clear and crystal here.
Hop, hop, hop, the clocks alignβ€”
In code and burrow, all is fine! πŸ•°οΈπŸ‡

[!NOTE]

⚑️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


πŸ“œ Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 1e1c887a2f59dc2fcef1bd139ddee990ddc28ddd and 8e3c411a3eaaf3687d3370d151295b890c3c826e.

πŸ“’ Files selected for processing (1)
  • deploy/docker/api.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • deploy/docker/api.py
✨ Finishing Touches
  • [ ] πŸ“ Generate Docstrings
πŸ§ͺ Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 13 '25 07:05 coderabbitai[bot]

@emmanuel-ferdman Many thanks for contributing, this is good. @ntohidi add this to upcoming release branch and merge it over there

unclecode avatar May 27 '25 15:05 unclecode

@emmanuel-ferdman hi, we will include it in our upcoming sprint.

ntohidi avatar Jul 14 '25 09:07 ntohidi

Hi πŸ‘‹ thx for the PR, @ntohidi plz check this soon

unclecode avatar Aug 20 '25 02:08 unclecode

Hi @emmanuel-ferdman Thank you for your contribution πŸ’œ. I've merged it with the develop branch, and it will be included in the next release in two weeks.

ntohidi avatar Aug 20 '25 02:08 ntohidi