node-deep-extend icon indicating copy to clipboard operation
node-deep-extend copied to clipboard

Browser?

Open ghost opened this issue 9 years ago • 7 comments

The title does include Node, but I was wondering if this is safe to use in the browser?

ghost avatar Jul 31 '15 06:07 ghost

According to the comments in this issue, it's not designed for the browser. I couldn't comment whether it works well across browsers though (was wondering the same myself).

mikehayesuk avatar Aug 24 '15 14:08 mikehayesuk

@chrismbeckett That's right, it wasn't designed for client-side, it have some node-specific stuff like Buffer. May be in the future it will be more compatible with front-end, for v1 release I'm planning to make some API for cloning special objects and move dealing with Buffers and other stuff like this to another sub-module as optional logic. Actually there's some pull request that I'm gonna use as prototype. But for now I guess you should use another module on client-side.

unclechu avatar Jan 16 '16 23:01 unclechu

Any chance browser support will be released any time soon?

husa avatar Jul 05 '16 10:07 husa

@husa If I have time for that, but no guarantees.

unclechu avatar Jul 05 '16 12:07 unclechu

Relevant PR: https://github.com/unclechu/node-deep-extend/pull/27

unclechu avatar Aug 19 '16 21:08 unclechu

Browserify implicitly adds a huge Buffer polyfill because of the buffer check. It's a part of documented browserify behavior but I don't think that it's a good idea to use the module in browser with the check.

everyonesdesign avatar Oct 19 '16 13:10 everyonesdesign

@everyonesdesign it will be optional behavior in next major release.

unclechu avatar Oct 22 '16 16:10 unclechu