silverstripe-gridfield-betterbuttons icon indicating copy to clipboard operation
silverstripe-gridfield-betterbuttons copied to clipboard

Published 20 hours ago • verified publisher icon unclecheese

Incorrect redirection when a Versioned DataObject is published

Open shaunjc opened this issue 7 years ago • 2 comments
trafficstars

https://github.com/unclecheese/silverstripe-gridfield-betterbuttons/blob/eeeb5b4700d565b32a43fb41a7df9a8333263a59/src/Extensions/GridFieldBetterButtonsItemRequest.php#L351-L353

$redirectURL is actually a \SilverStripe\Forms\FormRequestHandler instance, so users are always forced to incorrectly redirect to /SilverStripe/Forms/FormRequestHandler whenever a Versioned DataObject is published. Additional checks to ensure $redirectURL is a string should be added, or these lines should be removed.

shaunjc avatar Mar 14 '18 06:03 shaunjc

Any news on this? Will it be fixed?

andreaslindahl avatar Apr 10 '18 22:04 andreaslindahl

The SS4 upgrade is very much in flux, and I'm looking to wrap it up this week. See the feature/ss4-upgrade branch.

unclecheese avatar Apr 10 '18 22:04 unclecheese