silverstripe-gridfield-betterbuttons icon indicating copy to clipboard operation
silverstripe-gridfield-betterbuttons copied to clipboard

DataModel removed in ss4-beta4

Open jackoconnor21 opened this issue 8 years ago • 4 comments
trafficstars

DataModel has been removed in ss4-beta4 and so is causing breaks in GridFieldBetterButonsItemRequest.php on lines 75 & 89.

jackoconnor21 avatar Oct 25 '17 14:10 jackoconnor21

also, the class SilverStripe\ORM\Versioning\Versioned has moved to SilverStripe\Versioned\Versioned

tim-lar avatar Nov 08 '17 04:11 tim-lar

#170 Hopefully @unclecheese approves this. I have manually made these changes on my site to confirm it works.

mr-macedawg avatar Nov 30 '17 10:11 mr-macedawg

Hi uncle, all

Namespace also needs fixing in BetterButtonDataObject, just noticed...

Has anyone got this working for versioned dataobjects yet? Even with these fixes, for me the cms (4 stable) just hangs on loading (page reload)...

Martimiz avatar Dec 05 '17 18:12 Martimiz

~~I have raised a PR for this here: https://github.com/unclecheese/silverstripe-gridfield-betterbuttons/pull/172~~

I have closed my PR, somebody else has raised one here: https://github.com/unclecheese/silverstripe-gridfield-betterbuttons/pull/170

silverstripe-elliot avatar Jan 18 '18 04:01 silverstripe-elliot