silverstripe-dashboard icon indicating copy to clipboard operation
silverstripe-dashboard copied to clipboard

SS4 upgrade discussion

Open nspyke opened this issue 7 years ago • 8 comments

Hey @unclecheese As I discussed with you yesterday at StripeCon, I plan on upgrading this module to SS4. I'd like to open a discussion on the tasks needed to complete the upgrade.

  • Run upgrader tool
  • Namespacing
  • Check and upgrade data model relationships
  • ?

You mentioned that you'd like to remove some of the dashboards. I remember that you mentioned the Google Analytics dashboard. What were the other ones?

nspyke avatar Nov 24 '17 22:11 nspyke

I may be able to help out (although I am pretty stacked on workload at the moment).

From my perspective, it would be nice if dashboard could loose the CMS dependency, especially as SS4 has decoupled so much functionality into separate modules. SS is a very nice framework and adding dashboards to custom apps would be (in my opinion) a very nice feature.

I feel that the following panels would be better in their own module (not part of core):

  1. Google Analytics.
  2. Blog Entry.
  3. Maybe weather?

With regards to namespacing, I am guessing it would be: namespace UncleCheese\Dashboard\xxx

Finally, would you keep data model table names the same? If so, upgrading should be minimal really, if not then I am guessing a custom migration task will need creating (that would also cover point 1).

The only other thing that would need to be considered is if any of the JS needs updating. So far, in my experience, old Entwine code seems to work pretty well in 4, but there may be issues.

mlewis-everley avatar Nov 25 '17 14:11 mlewis-everley

Did work ever start on an SS4 branch?

adrian-stein avatar Jan 10 '18 22:01 adrian-stein

No. I ended up dropping this module from my upgrade project. I don't see myself working on it any time soon.

nspyke avatar Jan 10 '18 22:01 nspyke

I may get a chance to do some work on this soon (no guarantees though). I am going to need it to support some other modules I am upgrading to 4, but it really depends on if I can fit it in around other projects :-s

mlewis-everley avatar Mar 05 '18 09:03 mlewis-everley

How about creating the first SS4 compatible version without any of the default dashboards? Those could be upgraded and readded one by one to later minor versions.

That would satisfy projects that only use custom dashboards.

Taitava avatar Oct 04 '18 14:10 Taitava

I've started upgrading this the way I described in the above message (removed all default dashboards, those can be upgraded and brought back later). I'm not sure if I'm able to get it finished, but at least I'm trying. I'll push to this branch when I have it in a better shape: https://github.com/Taitava/silverstripe-dashboard/tree/ss4

So check that branch if there's no update in this discussion. If I'm not able to finish this, I'll at least push a WIP commit so someone else may get perhaps a little bit easier starting point.

Taitava avatar Oct 05 '18 17:10 Taitava

I'm quite close to completing the upgrade. Currently I need to test the changes with one or two of my projects. I'm not able to do comprehensive testing, but at least some. I will create a pull request after I'm done testing. In the meanwhile, I think others can test my branch too if someone is in a hurry or wants to help.

Taitava avatar Oct 06 '18 10:10 Taitava

My work mates and I have developed an alternate dashboard module that works with SilverStripe 4: https://github.com/plastyk/silverstripe-dashboard

If anyone is still waiting for an SS4 dashboard module, feel free to give it a go. Hopefully it is useful.

3Dgoo avatar Oct 26 '18 02:10 3Dgoo