silverstripe-dashboard icon indicating copy to clipboard operation
silverstripe-dashboard copied to clipboard

Composer deps need updating for 3.2

Open dhensby opened this issue 9 years ago • 8 comments

Is there a requirements for CMS at all with this module or does it just rely on framework/admin?

SiteConfig is a dependency and should be listed.

dhensby avatar Oct 29 '15 13:10 dhensby

That's a really good question. I don't know. Have you tried it with a headless framework?

unclecheese avatar Nov 18 '15 04:11 unclecheese

I just did a quick test and it appears to "work" but some of the default widgets depend on SiteTree (recent edits, for example).

Is there a way to just wrap them in if (class_exists('SiteTree')) so they don't appear if you don't have the SiteTree?

v3.2.1 sans CMS

dhensby avatar Nov 18 '15 11:11 dhensby

Yeah, that sounds like the simplest solution. Otherwise, we could break it off into two modules -- dashboard-core and dashboard-cms (with a dependency on the former).

There's a DashboardBlogEntryPanel in the core. That's even more presumptive than SiteTree!

unclecheese avatar Nov 18 '15 21:11 unclecheese

Love this module and the idea of slimming down it's dependancies sounds great. However is there any chance that in the mean time you could release an update that allows use in SS 3.2 (with dependancy on framework, cms, and siteconfig)?

nedmas avatar Dec 22 '15 12:12 nedmas

It's set to ~3.1.. that should allow minor release upgrades, right?

unclecheese avatar Dec 28 '15 21:12 unclecheese

Ah, maybe not. I think that should be ^3.1.

unclecheese avatar Dec 28 '15 21:12 unclecheese

~3.1 should allow 3.2 to work too or you can use ^3.1.1

dhensby avatar Jan 05 '16 08:01 dhensby

I think I tested the updating of canView checking for SiteTree and it did work... should get round to a PR some time...

dhensby avatar Jan 05 '16 08:01 dhensby