Niklas Correnz

Results 62 comments of Niklas Correnz

You shouldn't validate config _values_ at compile time. This breaks working with environment variables at runtime. Nobody should have to rebuild the container everytime the environment changes. That's often not...

Well, if danger is supposed to abstract the git layer here, it should behave indiscriminate of platforms. So if for github all files are included, then for gitlab the same...

@fbartho, so if the GitLab Provider is private, is this not the right repository for this issue? Where should I go with it to reach those GitLab-supporting-devs?

I've started to implement this feature and it looks promising. I've chosen an environment variable `DANGER_GITLAB_USE_THREADS` to enable it, so both are still supported and threads are opt-in. I'll open...

Be careful not to hard-code any folder names like `/danger/`, please! What I've done to out-source functions is this - very cumbersome at the moment: `ci/gitlab/dangerfile.ts` ```typescript import {danger, fail,...

@orta I suppose this is superseeded by #1331 and could be dropped?

This would be very helpful for migrating to 9.3 because of the deprecated at(). We have many at() with with(), which use constraints. Turning those into a withConsecutive() or willReturnMap()...

Is this extension using https://developer.chrome.com/docs/extensions/reference/storage/ ? If not, maybe that would help. I don't want to enable 3rd party cookies and losing the settings every reload drives me nuts :(

This hit us when trying to use a dedicated database for a Symfony RedisSessionHandler. Cache keys kept appearing in the wrong database. In fact, only keys for db `0` end...