gradle-helm-plugin
gradle-helm-plugin copied to clipboard
unbroken-dome
Support Gradle 8
Gradle 8 introduced a breaking change for abstract classes : https://docs.gradle.org/8.0-rc-1/userguide/upgrading_version_7.html#plugins_tasks_and_extension_classes_are_abstract
When running the plugin on the Gradle 8 RC1, something like this shows : org/gradle/api/internal/plugins/AbstractRule
Bump! Could anyone comment on this? The answer that this project is no longer maintained is also ok, because it would let us plan accordingly.
These plugins are no longer being maintained by the looks of things. That is why we have stopped using them and replaced them with shell scripts.
@NikolayMetchev i tried today to upgrade your codebase. It's just that 223 tests are failing even without changes to your code. Would you accept a pull request with the failing tests? Are you planning of maintaining your fork?
No worries I forked it.
sorry I have deleted my fork. @NikolayMetchev https://github.com/mehmetsalgar/gradle-helm-plugin
Are you sure?
I published the plugin and it is in review right now. I had to publish a working draft so my colleges can work on the helm chart. It compiles with gradle 8 and Java 17. But the upgrade feels a little bit messy and I still didn’t figure out why some of the test are failing. I guess I will create an official fork after I setup CI/CD.
Unfortunately, my plugin was rejected because there are already some forks in the Gradle portal and one of the Gradle staff thinks that some of the forks are active. None of it work with gradle 8, so it's annoying, but it is what it is.
I wrote @mehmetsalgar an email if he is interested to collaborate.
Otherwise i will have to rename the plugin to helmng or something like that.
@bullshit
Hi, I forked the plugin for
https://github.com/unbroken-dome/gradle-helm-plugin/pull/164
and later on added some additional features like working with OCI Registries as Helm Chart repositories but to say the truth I worked quite un-formal just reach my goals....
If the Gradle plugin management making so much stress about the forking the plugin of course we can continue on my fork...
But noway I want to offend the developer of the original plugin, by steering all new development to my fork....
I' was able to publish a Gradle 8 version of the plugin by renaming it. (https://plugins.gradle.org/search?term=io.github.bullshit.helmng) Please note that it is still a alpha version, and I'm aware that there might be some issues with Helm publish due to failing tests. Basically i just tried to fix the compile errors and in the next few weeks i will use it as a CI/CD playground.
Regarding the fork of the original project, I should stay compliant with the DSL of the original project. It would be great if the maintainer, @tkrullmann, could give us access to his repository, but until then, we should officially fork the project. We can always merge our changes back in the future.
I'm excited to set up some Github Actions for testing and releasing the plugin, and I'm happy to assist with any Gradle 8 issues that may arise. Thank you for considering this opportunity to improve the plugin!"
I have some questions:
- Should we enable the discussion and issue feature in your repository and of this conversation there?
- Would it be okay if i setup the CI/CD to use https://www.conventionalcommits.org/en/v1.0.0/ and https://github.com/mooltiverse/nyx to automate the release process?
- Would you be so kind and add me as a collaborator to your project?
- Do you wanna meetup in a jitsi call? I'm from europe and fluent in german and polish as well.
Support for Gradle 8.x has been added in https://github.com/unbroken-dome/gradle-helm-plugin/releases/tag/v2.0.0.
Just a small heads up for those in this thread that this codebase is no longer actively maintained. As the original author recommends, you are welcome to open an issue or suggest improvements here instead.
Our maintainers and contributors will be happy to support! ❤️
