shake icon indicating copy to clipboard operation
shake copied to clipboard

Fallback on posix_fallocate if fallocate fail

Open Celelibi opened this issue 3 years ago • 2 comments

Not every FS support the fallocate system call. Falling back to posix_fallocate would allow more compatibility at the expense of some performance penalty. But I think it's worth it. Maybe with a one-time warning?

Celelibi avatar Mar 12 '22 17:03 Celelibi

Which OS do you have in mind? On GNU/Linux, posix_fallocate is implemented using fallocate (see posix_fallocate.c), so that wouldn't increase compatiblity.

unbrice avatar Mar 12 '22 18:03 unbrice

In the glibc posix_fallocate is implemented using the fallocate syscall first. But falls back onto an emulated implentation if the syscall fail with EOPNOTSUPP. This implementation should work on almost every file system.

Celelibi avatar Mar 15 '22 15:03 Celelibi