pytorch-tree-lstm icon indicating copy to clipboard operation
pytorch-tree-lstm copied to clipboard

Published 20 hours ago • verified publisher icon unbounce

I think these dimensions are off in the comment

Open tslevi-unbounce opened this issue 5 years ago • 2 comments

https://github.com/unbounce/pytorch-tree-lstm/blob/66f29a44e98c7332661b57d22501107bcb193f90/treelstm/tree_lstm.py#L92

tslevi-unbounce avatar Jun 25 '19 17:06 tslevi-unbounce

Yes I agree. It should be e x out_features . Also c[node_mask, :] = i * u will not work because c dimension is [batch_size,out_features] and batch_size and node_mask doesn't have to be same. Batch_size is one in case of single tree. Did you stumble upon the same problem?

shravansingh123 avatar Dec 19 '19 11:12 shravansingh123

https://github.com/unbounce/pytorch-tree-lstm/blob/66f29a44e98c7332661b57d22501107bcb193f90/treelstm/tree_lstm.py#L116

shravansingh123 avatar Dec 19 '19 11:12 shravansingh123