data_science_in_julia_for_hackers icon indicating copy to clipboard operation
data_science_in_julia_for_hackers copied to clipboard

Published 20 hours ago • verified publisher icon unbalancedparentheses

Chap 7 feedback

Open salbert83 opened this issue 3 years ago • 2 comments

I believe the following code: #Team-specific effects
att ~ filldist(Normal(μatt, σatt), length(teams)) def ~ filldist(Normal(μatt, σdeff), length(teams))

should be changed to # Team-specific effects att ~ filldist(Normal(μatt, σatt), length(teams)) def ~ filldist(Normal(μdef, σdef), length(teams))

Otherwise, I believe there may be a convergence issue.

salbert83 avatar May 04 '21 00:05 salbert83

Hi @salbert83, first of all thanks for taking the time to read the book and for the feedback. We will check this in the following and solve it.

Fede.

unbalancedparentheses avatar May 04 '21 00:05 unbalancedparentheses

Also, regarding this line: "posterior = sample(model, NUTS(),3000);" perhaps a comment that this could take some time depending on one's machine. Thanks for making this preview available.

salbert83 avatar May 04 '21 00:05 salbert83