inbox
inbox copied to clipboard
feat: remove global store
What does this PR do?
- Removed the global store which fixes all random toasts.
- Now for getting org code you can use
useOrgShortcode(). - There is also
useOrgScopedRouterwhich provides functions to navigate inside a org. For example if you want to go to/[orgShortcode]/convo/new, you can doscopedNavigate('/convo/new') - Changed 2 routes in platform. One checks if you have access to the org/ org exist. Other one returns username along with orgProfile.
How to Test
Test Everything, Nothing should break but still we need to make sure, I already did extensive testing everything works as expected with no random error toasts
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Chore (refactoring code, technical debt, workflow improvements)
- [ ] Enhancement (small improvements)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
Checklist
Required
- [ ] Read Contributing Guide
- [ ] Self-reviewed my own code
- [ ] Tested my code in a local environment
- [ ] Commented on my code in hard-to-understand areas
- [ ] Checked for warnings, there are none
- [ ] Removed all
console.logs - [ ] Merged the latest changes from main onto my branch with
git pull origin main - [ ] My changes don't cause any responsiveness issues
Appreciated
- [ ] If a UI change was made: Added a screen recording or screenshots to this PR
- [ ] Updated the UnInbox Docs if changes were necessary
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @BlankParticle and the rest of your teammates on
Graphite