remark42
remark42 copied to clipboard
Mobile navigation to comment doesn't work for hidden comments
If a comment not shown on the first screen, anchor navigation doesn't work.
For example, this link (on mobile) may not work for some sortings (best, maybe others) https://radio-t.com/p/2018/06/12/prep-602/#remark42__comment-68d9aace-67f7-47b6-9f6c-ae8bdbe7fbdd
@umputun I guess it could be solved if render all comments even on mobile if remark comment link is present in url. Of course it is preferable to check if comment is already visible first, but it's would be much harder to implement.
@Guria, great idea, thanks.
I'm not sure that it would be much harder to implement logic of checking, because we can just check a position of comment in the list (yep, it can be a reply, but it isn't hard to find root comment and get its position). If it's lower that limit of showing — we don't need to do anything. If it's not, we just increase the limit, and everything should work fine.
@Guria , @igoradamenko I've created a fix addressed to this issue, please take a look.
Can reproduce in the current master with link above: works on desktop but not on mobile.
hi, here's a fix that should fix this https://github.com/umputun/remark42/pull/983
It works in the latest stable version, resolving.