remark42 icon indicating copy to clipboard operation
remark42 copied to clipboard

Add new comments highlighting

Open zedxxx opened this issue 5 years ago • 6 comments

It is a common feature when comments that was added since last visit are highlighted. It would be great if remark could do it too.

zedxxx avatar Dec 12 '19 19:12 zedxxx

I like the idea and I think this can be done on the frontend side only. @Reeywhaar - do you see any problem with this?

umputun avatar Dec 12 '19 20:12 umputun

@umputun It looks like a good idea! I can do it. How I can get info about the last user visit?

StaroKep avatar Dec 28 '19 13:12 StaroKep

@StaroKep I think you can save it local storage and check it later. @Reeywhaar what do you think?

akellbl4 avatar Dec 30 '19 19:12 akellbl4

@akellbl4 It's not a good idea. I can use many devices. We can get information from backend. I think it's more correct for this case.

StaroKep avatar Dec 30 '19 22:12 StaroKep

I agree with @akellbl4 - to me, it sounds like UI-only thing. @StaroKep - sure, it won't work across multiple devices, but this is not the goal. The goal (at least for now) is to realize what's new since the user visited from the particular device.

Technically implementing "last viewed" on the server-side is not an easy task and I see no way doing it for read-only (i.e. not logged in) users at all. Even for authenticated users, it won't be easy as we don't record/track user activity and remark42 is trying to know as little as possible about users. In fact, we have no clue what the user did before and there is no place we record user's history, except the obvious parts we have to know, i.e. the actual commenting and voting.

Recently @paskal added the ability for email subscription and this functionally requires authorized users to enter and confirm email explicitly and also provides a way to clear this data. Theoretically, smth similar can be done to save the last-visited timestamp on each post, but this won't address the problem for anonymous readers and I don't think the convenience of continuity justifies relaxed privacy requirements in this case.

umputun avatar Dec 30 '19 23:12 umputun

@umputun I understand. OK.

StaroKep avatar Dec 31 '19 08:12 StaroKep