remark42 icon indicating copy to clipboard operation
remark42 copied to clipboard

fix: ui error when no auth providers configured

Open Jaskon opened this issue 1 year ago • 2 comments

This issue

image

Please correct me if i'm wrong: view variable (telegram/token/email) is only exist after some action in the dropdown menu. So its not necessary to check here that view is equal to something and checks provided in my PR is enough

Jaskon avatar Jun 09 '23 16:06 Jaskon

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% :tada:

Comparison is base (c9b6f92) 61.55% compared to head (74fd5a8) 61.57%. Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
+ Coverage   61.55%   61.57%   +0.02%     
==========================================
  Files         133      133              
  Lines        3004     3006       +2     
  Branches      752      761       +9     
==========================================
+ Hits         1849     1851       +2     
- Misses       1038     1151     +113     
+ Partials      117        4     -113     
Files Changed Coverage Δ
...pps/remark42/app/components/auth/auth.messsages.ts 100.00% <ø> (ø)
...rontend/apps/remark42/app/components/auth/auth.tsx 81.69% <100.00%> (+0.26%) :arrow_up:

... and 24 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 09 '23 16:06 codecov[bot]

@Jaskon can you please finalise that PR so that we could merge it?

paskal avatar Jun 02 '24 22:06 paskal