remark42 icon indicating copy to clipboard operation
remark42 copied to clipboard

Published 20 hours ago • verified publisher icon umputun

automatic PR deployment

Open umputun opened this issue 6 years ago • 2 comments

The goal is to deploy each PR automatically and make it available on https://pr.remark42.com/{{PR-NUM}}

umputun avatar Jul 06 '18 20:07 umputun

We can see working example at https://github.com/CompuIves/codesandbox-client/pulls Each PR contains a link to published build in checks section at bottom. Eg, http://pr947.cs.lbogdan.tk/s/new

Not a high priority, but nice to have

Guria avatar Jul 06 '18 21:07 Guria

The information which was discussed somewhere but was not written down yet: this is a tricky issue because of security precautions, as we don't want to auto-deploy just everything we get a PR on because we don't know what is it inside.

As I was writing this I thought that having a non-automatic way that is available by a button (or by PR tag or any other manual-triggered mechanism) would solve the problem for PR reviewer and at the same time won't have security problems of automatic deploy.

paskal avatar Mar 09 '20 22:03 paskal