list-generator icon indicating copy to clipboard operation
list-generator copied to clipboard

Add github actions for PHP 7.4, 8.0 and 8.1, Symfony 5.3, 5.4 and 6

Open tacman opened this issue 4 years ago • 3 comments

This PR adds github actions to check for the supported versions of PHP and Symfony.

tacman avatar Nov 29 '21 13:11 tacman

Thanks!

umpirsky avatar Nov 29 '21 13:11 umpirsky

CI is blocking merge.

umpirsky avatar Nov 29 '21 13:11 umpirsky

I made some tweaks, but not sure it's right.

Also, I split up the SimpleXMLExtended class into its own file (for PSR-4). But something is wrong with the addCData -- it returns void, so it doesn't make sense to add it as a value.

Tests are passing, but please review that section.

On Mon, Nov 29, 2021 at 8:36 AM Saša Stamenković @.***> wrote:

CI is blocking merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/umpirsky/list-generator/pull/10#issuecomment-981640798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQNVB3URY7VGRINWCOTUON6UFANCNFSM5I7DXQQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

tacman avatar Nov 29 '21 14:11 tacman