umi
umi copied to clipboard
fix(mfsu): add args to MFSU worker
fix: #10097
改动点:
- 传递
api.args给 MFSU 启用的 Worker 对象 - 当 MFSU 使用 ESBuild 进行打包时,增加
api.config.define
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Updated |
|---|---|---|---|
| umi | ⬜️ Ignored (Inspect) | Dec 22, 2022 at 5:32AM (UTC) |
Codecov Report
Base: 29.90% // Head: 29.89% // Decreases project coverage by -0.01% :warning:
Coverage data is based on head (
2d9d658) compared to base (2ac58dc). Patch coverage: 0.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #10109 +/- ##
==========================================
- Coverage 29.90% 29.89% -0.02%
==========================================
Files 432 433 +1
Lines 12400 12405 +5
Branches 2969 2971 +2
==========================================
Hits 3708 3708
- Misses 8125 8130 +5
Partials 567 567
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/bundler-webpack/src/dev.ts | 0.00% <0.00%> (ø) |
|
| .../src/commands/dev/depBuildWorker/depBuildWorker.ts | 0.00% <0.00%> (ø) |
|
| ...t-umi/src/commands/dev/depBuildWorker/getConfig.ts | 0.00% <0.00%> (ø) |
|
| ...reset-umi/src/commands/dev/depBuildWorker/types.ts | 0.00% <0.00%> (ø) |
|
| packages/preset-umi/src/commands/dev/dev.ts | 0.00% <ø> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
- worker 启动的时候把 argv 传过去 https://github.com/umijs/umi/blob/f16dfdffce15ba8b961f14329b976a74e68c0292/packages/preset-umi/src/commands/dev/dev.ts#L279-L281
- getConfig 时候把 args 解析出来给到参数里面 https://github.com/umijs/umi/blob/f16dfdffce15ba8b961f14329b976a74e68c0292/packages/preset-umi/src/commands/dev/depBuildWorker/getConfig.ts#L10
这样是不是会更简单点