umi icon indicating copy to clipboard operation
umi copied to clipboard

Feat/mfsu rebuild when patch

Open mysteryven opened this issue 3 years ago • 5 comments

support #10064

mysteryven avatar Dec 14 '22 14:12 mysteryven

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
umi ⬜️ Ignored (Inspect) Dec 17, 2022 at 1:13PM (UTC)

vercel[bot] avatar Dec 14 '22 14:12 vercel[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@835d353). Click here to learn what that means. Patch coverage: 93.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #10065   +/-   ##
=========================================
  Coverage          ?   30.36%           
=========================================
  Files             ?      433           
  Lines             ?    12431           
  Branches          ?     2976           
=========================================
  Hits              ?     3775           
  Misses            ?     8089           
  Partials          ?      567           
Impacted Files Coverage Δ
packages/mfsu/src/staticDepInfo/staticDepInfo.ts 29.32% <80.00%> (ø)
packages/mfsu/src/depInfo.ts 64.44% <90.90%> (ø)
packages/mfsu/src/utils/patchesHashUtil.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Dec 14 '22 14:12 codecov[bot]

@fz6m

首先非常感谢您一直认真的帮我找出代码规范的问题。看着每次 PR 都有那么多问题,找出来一定很辛苦,并且不是一个愉快的工作,我也觉得挺过意不去。但是目前自己认知水平达不到,在提交之前也看不出问题。

请问可以给一个您认可的编码规范的文档吗?虽然有些情形考虑不到,还是需要别人指点,但是我也希望提交的代码在代码风格上尽量别再有这么多的问题 =.=

mysteryven avatar Dec 16 '22 06:12 mysteryven

我是很久以前看过一些零散的文章,不过你可以去 juejin 搜一下 代码风格 ,我看了下很多文章都有总结。

关于 code style ,我提的建议也是自己的看法,见仁见智,千人千面。

fz6m avatar Dec 16 '22 12:12 fz6m

上次看你的提交,如果对 TypeScript 的类型不熟,可以用 typescript 万字长文类型体操typescript 高级类型typescript 泛型 关键词搜一些文章看看。

这里还有一些题目可以看看:https://github.com/type-challenges/type-challenges

fz6m avatar Dec 17 '22 12:12 fz6m