umee icon indicating copy to clipboard operation
umee copied to clipboard

Add comments to the historacle proto

Open zarazan opened this issue 3 years ago • 1 comments

Summary

There was some confusion about if the denom used is symbol or base denom: "For historacle MedianOfHistoricMedians(ctx, denom, numStamps), is denom the token’s base denom or symbol denom? Assuming symbol for now"

Problem Definition

Robert: "we need to add more comments to the proto."

Proposal

Add comments


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

zarazan avatar Dec 12 '22 18:12 zarazan

We should also consider renaming. I was discussing similar thing for x/leverage with @toteki and we were brainstorming about few options, but didn't find ideal solution.

robert-zaremba avatar Dec 12 '22 21:12 robert-zaremba