htsget-rs icon indicating copy to clipboard operation
htsget-rs copied to clipboard

UrlStorage blacklist of forwarded headers

Open KrKOo opened this issue 1 year ago • 2 comments
trafficstars

This PR introduces the ability to define headers that should not be forwarded when forward_headers is enabled, as described in issue #243.

Example config

...
[resolvers.storage]
url = "http://localhost:8080"
response_url = "https://example.com"
forward_headers = true
header_blacklist = ["Host"]
...

KrKOo avatar May 16 '24 15:05 KrKOo

This is great, thanks @KrKOo! I'm missing some documentation though, could you please describe your example in the docs and provide the resolver config you mentioned in the description of this PR?

Thanks again!

@mmalenic Any other observations? Does this PR fit with your recent hyper->reqwest transition?

brainstorm avatar May 16 '24 23:05 brainstorm

Hey, while writing the docs, I realized that the headers were not removed from the request made by htsget-rs to the resource server, so I added that as well.

KrKOo avatar May 17 '24 12:05 KrKOo

This is great, thanks @KrKOo!

mmalenic avatar May 19 '24 23:05 mmalenic

Thanks again @KrKOo for your contribution! 🎉

brainstorm avatar May 19 '24 23:05 brainstorm