Umbraco-CMS icon indicating copy to clipboard operation
Umbraco-CMS copied to clipboard

Umbraco 14 - Block Grid Area size does not save

Open deanleigh opened this issue 1 year ago • 9 comments

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14

Bug summary

Block Grid Area sizes are lost on save

Specifics

No response

Steps to reproduce

Create a block grid Create a layout Resize an area in that layout Save it the size is lost

Expected result / actual result

Sizes of areas would stay as saved


This item has been added to our backlog AB#41872

deanleigh avatar Jun 20 '24 19:06 deanleigh

Hi there @deanleigh!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

github-actions[bot] avatar Jun 20 '24 19:06 github-actions[bot]

Duplicate of #16372 ?

JoJk0 avatar Jun 21 '24 08:06 JoJk0

I think it is the same but I am seeing the columns at 6 columns by default. So even changing a single column from 6 to 12 and save it goes back to 6.

deanleigh avatar Jun 21 '24 10:06 deanleigh

Hi both 👋 thanks for reaching out!

We are already working on the column issue with the block grid, so I will close this as duplicate 🙂

elit0451 avatar Jun 24 '24 09:06 elit0451

Hi everyone, this issue is related to the configuration of the area sizes in the block grid configuration, whereas #16372 concerns saving content blocks with varying sizes. I would reopen this issue to address both problems, even though they might be overlapping.

iOvergaard avatar Jun 24 '24 12:06 iOvergaard

Hi @deanleigh

Thanks for reporting this, I have checked your case with latest code base, thats v.14.1. and here it is working.

Just to be sure my approach that is working is the following:

  • Create a Document Type,
  • Append a Property with a DataType of Block Grid Editor with two Block Types.
  • Block Type A, is allowed in the root and has two areas.
  • Block Type B, is allowed in areas and is configured for 4 different column spans, 3,6,9,12.
  • Create a Document of that type
  • Create Block Type A
  • Create two Block Type Bs inside Block Type A.
  • Resize the Blocks so they become ColumnSpan 3 and thereby fits next to eachother.
  • Save it
  • And verify that document was saved.

nielslyngsoe avatar Jun 24 '24 14:06 nielslyngsoe

Hey @nielslyngsoe that sounds like the same steps so great news if that is fixed

deanleigh avatar Jun 24 '24 14:06 deanleigh

I'm not sure this is fixed, or a different issue. but if you just add a block element and give it allow in root and two areas of say size 8 and 4, then save. The block element just defaults back to 2 6 column areas

huwred avatar Jun 27 '24 09:06 huwred

Thanks, @huwred, I will re-open this to investigate.

iOvergaard avatar Jun 27 '24 09:06 iOvergaard

Ok, this one should now be fixed in RC2 released yesterday. Go and check it out 👍

iOvergaard avatar Jul 05 '24 07:07 iOvergaard

looks good :)

huwred avatar Jul 05 '24 08:07 huwred