Umbraco-CMS icon indicating copy to clipboard operation
Umbraco-CMS copied to clipboard

Unable to correct a short invalid alias on a property

Open richarth opened this issue 1 year ago • 2 comments

When adding a new property with a short name such as A, an invalid alias will be created.

If you then correct just the alias you won't be able to save your new property. I've added a Playwright test which demos this.

You can get around this by changing the name and the alias but it isn't immediately obvious, as the error on the name isn't flagged.

I've also added a screen recording of the problem below.

https://github.com/umbraco/Umbraco-CMS/assets/283888/29e1dfb3-8680-4fff-b82b-025551211f41

richarth avatar Feb 19 '24 18:02 richarth

Hi there @richarth, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • [x] 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

github-actions[bot] avatar Feb 19 '24 18:02 github-actions[bot]

Hello @richarth ,

Thank you for writing this Playwright test to check this scenario 👍 A member of the core collaborators team will have a look at it soon!

mikecp avatar Feb 20 '24 00:02 mikecp

Hey @richarth, thanks for contributing the test!

Since this adds a failing test, we can't really merge the PR without also including a fix for the issue described.

I'm going to mark this as a DRAFT for now, until we can get the bug itself fixed. I'm also going to create an issue to give the problem a bit more visibility.

JasonElkin avatar Feb 25 '24 16:02 JasonElkin