Media upload in root media folder crashes when user has media startnode

[ipsisPuckHolshuijsen]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.1.0

Bug summary

If a user has a media start node set, I can still see the menu on the media root to upload files. When trying that, my console gives an error in angular.js

Specifics

No response

Steps to reproduce

Create a new user group with a media startnode set. In my case it's a folder inside the media library:

After the group is added to the user, I am only able to see the set startnode, but still able to choose to upload a file in the media root.

When trying to upload a file under the media root, the button keeps spinning and in the console i can see an error.

Expected result / actual result

Even though I am not able to upload any file due to the angular.js error, I didn't expect to see the menu in the media root at all.

[github-actions[bot]]

Hi there @ipsisPuckHolshuijsen!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

[Migaroez]

Hey @ipsisPuckHolshuijsen, thank for the bug report. I was very easy to reproduce this thanks to your reproduction steps and screenshots.

Taking a closer look at the UI, it seems like the system actually figures out the limited user can't create something under the root as the title of the popout menu says "reload" and that is the only option in the full menu as shown by clicking on the do something more.

So there seems to be a slight oversight in the logic that shows the quick actions menu when left clicking but the right click full menu is ok.

I am going to mark this one as up for grabs as all pieces to make this behave correctly on the front end seem to be available.

I have a feeling this behavior might be on all versions since 7 which we need to keep in mind when merging.

[github-actions[bot]]

Hi @ipsisPuckHolshuijsen,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[ipsisPuckHolshuijsen]

@Migaroez

Glad that you were able to reproduce it easily! I just found this out in this version, because I never needed it before this project I am currently working on, but it might as well be in here since V7 :)

Luckily you can't really upload anything in the media root - which is a good thing - but it would just be nice to not see the upload possibilities in the quick actions menu :)

[AdamPrendergast]

I'm happy to take a look at this issue if it has not been picked up already.

I've also noticed similar behaviour when no Media Types are allowed for creation at the root, it still says they are in the UI.

[AdamPrendergast]

@Migaroez Added a Draft PR for this issue here: https://github.com/umbraco/Umbraco-CMS/pull/15671

It will definitely need a discussion to ensure we cover off the multiple scenarios of how and where a Media start node can be set (specifically, individual user & group)