Make InstallMissingDatabase nullable.

[nagolucky18]

InstallMissingDatabase should be nullable so that if 1. the variable is false, Umbraco will not install missing database under any circumstances and 2. if the variable is null, the installation of the missing database is deferred to CanForceCreateDatabase and 3. if the variable is true, the missing database will always be created.

Prerequisites

• [] I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes 14956

Description

[github-actions[bot]]

Hi there @nagolucky18, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• [x] 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[busrasengul]

Thank you @nagolucky18 Someone from the core team or HQ will look into this soon!!

[emmagarland]

Hi @nagolucky18!

I was going through some of the PRs, and noticed this one was in draft.

I was just wondering if you needed any discussions or assistance to help move this one forwards at all? If so, please let us know if we can help! Otherwise, we'll leave it here until you're ready for us to review. 🙂

Thanks,

Emma

[nagolucky18]

Hi @nagolucky18!

I was going through some of the PRs, and noticed this one was in draft.

I was just wondering if you needed any discussions or assistance to help move this one forwards at all? If so, please let us know if we can help! Otherwise, we'll leave it here until you're ready for us to review. 🙂

Thanks,

Emma

It looks like I just need to add the steps to test. I'll do that soon. Thanks for checking in!

[nagolucky18]

@emmagarland I actually had to revisit the comments on the actual issue to make sure everything was OK. I had to make some adjustments based on an earlier comment. See https://github.com/umbraco/Umbraco-CMS/issues/14956#issuecomment-1903361069

[AdamPrendergast]

Hey @nagolucky18

Firstly, thanks for picking up this issue - I currently am relying on a work around.

Let me know if you need any support getting it over the line as I could also do with this being resolved.

All the best, Adam

[JasonElkin]

We've not had any movement on this, and it's not necessarily the best way to handle https://github.com/umbraco/Umbraco-CMS/issues/14956 - which is a configuration issue.

I'm going to close this for now. If anyone wants to revisit this then we can reopen it at a later date.