Removing can connect to database check so that Umbraco errors out on …

[gilbertaoe]

…startup rather than trying to re-install when unable to connect to database.

Prerequisites

https://github.com/umbraco/Umbraco-CMS/issues/13042

Description

A bug was reported that when an existing database string is present for a previously installed database, but the database is unreachable (in this case the firewall was blocking all connections), then the install screen is shown rather than a startup error.

[github-actions[bot]]

Hi there @gilbertaoe, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• [x] 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[gilbertaoe]

@mikecp How can I re-run these PR checks?

[mikecp]

Hi @gilbertaoe , If you click on the "details" link on one of the checks, you get to the details screen (obviously 😅) from where you have a link to re-run

If the re-run fails, I invite you to have a quick look in the details to see if the problems are actually due to your changes, because sometime those tests fail "randomly" for reasons not linked to your changes...

Hope this helps 😁

[gilbertaoe]

@mikecp Ah, that makes sense why I didn't see it earlier, because it's not there when I view the details! Are special user permissions required to se the "re-run" button?

Regardless of whether I'm able to re-run the tasks or not I'll check out if the errors were random or not. Thanks!

[bergmania]

The errors in build is due to the breaking change..

[bergmania]

I will try to fix up, and make it ready for v10.3

[bergmania]

Can't make fit happy.. I cherry picked your commit here https://github.com/umbraco/Umbraco-CMS/pull/13118

[mikecp]

Hi @gilbertaoe , thanks for providing the fix for this! Unfortunately, as @bergmania mentioned, adding (or removing) public elements are considered breaking changes, so this is why the build crashed + we cannot merge this in a minor version... My apologies that I did not spot this to tell you right away 😬 But I'm sure your next one will be good to go 😁 Cheers!

[gilbertaoe]

@bergmania @mikecp I've been on vacation the past few days so I missed these messages, thanks for pointing this out. I'll get this fixed up if it still needs to be done