Redirect to a return URL if one is present on the querystring when lo…

[justin-nevitech]

Fixes issue:

https://github.com/umbraco/Umbraco-CMS/issues/13011

this fixes #13011

Added logic to $routeChangeError handler in init.js to check for a ReturnURL on the querystring and if present, sets the returnRath to the ReturnURL. This allows back office logins to redirect correctly if a ReturnURL is present which was previously being ignored. Existing logic used when no ReturnURL is present.

Testing:

Tested that the back office login redirects to an UmbracoAuthorizedApiController controller action after login and also checked that existing back office URLs are redirected correctly after login when no RedirectURL is present.

All tests checked and passed.

See issue 13011 for more details.

[github-actions[bot]]

Hi there @justin-nevitech, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• [x] 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[justin-nevitech]

this fixes #13011

[mikecp]

Hi @justin-nevitech , as promised yesterday on Twitter 😁 Nice fix 👍🎉This had probably impact on quite some people! I'll be looking forward to your next PR 😉 Cheers!

[justin-nevitech]

Super, thanks @mikecp :-)

[jrunestone]

Thanks @justin-nevitech much appreciated