Umbraco-CMS
Umbraco-CMS copied to clipboard
Fix issue 13023 - Cannot read properties of undefined (reading 'allow…
this fixes #13023
Added check to propertyEditorReadonly() function in listview.controller.js to ensure $scope.variantContent is defined before accessing $scope.variantContent.allowedActions.
See issue 13023 for more details.
All tests checked and passed.
Hi there @justin-nevitech, thank you for this contribution! 👍
While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
- It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
- The automated tests all pass (see "Checks" tab on this PR)
- The level of security for this contribution is the same or improved
- The level of performance for this contribution is the same or improved
- Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
- If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
- [x] 💡 The contribution looks original and the contributor is presumably allowed to share it
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.
If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.
Thanks, from your friendly Umbraco GitHub bot 🤖 🙂
this fixes #13023
Thanks @justin-nevitech for spotting and fixing this 👍 I think the console will be very thankful 😅 Cheers!
If the console's happy I am happy!
Will see if I can get some more PRs in for Hacktoberfest!