Umbraco-CMS icon indicating copy to clipboard operation
Umbraco-CMS copied to clipboard

Published 20 hours ago • verified publisher icon umbraco

Renames Installer form from "myForm" to "installerForm"

Open krebil opened this issue 2 years ago • 1 comments

Prerequisites

  • [x] I have added steps to test this contribution in the description below

This fixes 12771

Description

This simply renames the forms in the installation steps. Since the value is static, this can be tested by inspecting the page or viewing the source code.

krebil avatar Aug 09 '22 10:08 krebil

Hi there @krebil, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • [x] 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

github-actions[bot] avatar Aug 09 '22 10:08 github-actions[bot]

Hi @krebil, thanks for this PR, it seems to work fine.

I've merged in the subsequent changes and also retargeted this to v11.

glombek avatar Oct 21 '22 19:10 glombek

Hi @krebil, thanks for this PR, it seems to work fine.

I've merged in the subsequent changes and also retargeted this to v11.

glombek avatar Oct 21 '22 19:10 glombek

Cherry picked for 10.4.0 67d6e9f3df9700e4aad7645c66d33ef8e2da5be7

nul800sebastiaan avatar Dec 14 '22 12:12 nul800sebastiaan