Umbraco-CMS icon indicating copy to clipboard operation
Umbraco-CMS copied to clipboard

RTE property validation does not work properly in block lists

Open Andrei- opened this issue 3 years ago • 6 comments

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

8.13, 9.3.1

Bug summary

I have an FAQ block item where I can add multiple items of type FAQItem. An FAQItem has two properties: Question[textstring,mandatory] Answer[Rich Text,mandatory]

The issues:

  1. On create, the FAQItem only validates the first property even though both are set to mandatory. So I can create an FAQItem with non-empty Question and empty Answer. Then I can submit and close the editing UI an try to save & publish. Only now I'm getting a validation error for the second input.
  2. Trying to fix by adding a value in the Anwer field (RTE input) - the submit button is not working any more. So I can only continue if I completely remove the FAQItem and start again.

Specifics

No response

Steps to reproduce

Made a short video to illustrate both issues

https://user-images.githubusercontent.com/6005180/141848182-9dd5fa33-24a8-408f-af48-f7ff9975f679.mp4

Expected result / actual result

No response

Andrei- avatar Nov 15 '21 20:11 Andrei-

We've done a lot of work on validation in the last few releases of Umbraco, make sure to try again on Umbraco 8.17! If this is still an issue on 8.17 then we can look at it and re-open the issue.

nul800sebastiaan avatar Nov 17 '21 11:11 nul800sebastiaan

We have upgraded to v9.3.1 and this seems to still be an issue

Andrei- avatar May 03 '22 09:05 Andrei-

@nul800sebastiaan Can we have this re-opened, so I don't have to create this all over again? 🙂

Andrei- avatar May 04 '22 14:05 Andrei-

Hi @Andrei-,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)

umbrabot avatar May 04 '22 14:05 umbrabot

I'll add a package to reproduce this (can still repro in v9.5) here: MyCustomUmbracoPackage.1.0.2.nupkg.zip

  • Unzip this somewhere, like D:\NuGetRepo
  • In your site run: dotnet add package MyCustomUmbracoPackage --source D:\NuGetRepo
  • The package will install with a Testing node that has a required Textstring and required Rich Text editor on it
  • Notice that the validation of the RTE never fires

I will assume this is going to be a really tricky issue, it could be that the validator can't detect that the RTE is empty because some kind of value still is set for it? Not sure.

Luckily we can't actually save or publish anyway as that is properly validated (see video). So it's just this tiny step that's going wrong.

https://user-images.githubusercontent.com/304656/166708794-110c9f31-3786-4656-b31d-ecc298f315e7.mp4

nul800sebastiaan avatar May 04 '22 14:05 nul800sebastiaan

@nul800sebastiaan , we are running into the identical bug described in the original ticket too. Very frustrating! We're running Umbraco 9.5.2.

I know there's a secondary validation check when you attempt to save and/or publish, but that's not sufficient after the user has added quite a number of blocks with rich text fields inside the content, as they then have to go back through every one of them and make edits.

Really hope you can address this soon.

timeverts avatar Aug 26 '22 03:08 timeverts

This can be reproduced in V10 as well, so the issue is ongoing.

We'd love some help getting to the bottom of this 🙏

kjac avatar Jan 12 '23 19:01 kjac

@nul800sebastiaan We can still reproduce this issue on Umbraco 13.2.0. Is there an update coming that fixes this issue?

gerrit-de-heij avatar Mar 08 '24 13:03 gerrit-de-heij