Unai Martinez-Corral


@hilary, I saw that you merged this PR on your fork a couple of months ago. Is it working ok for you? Did you need to apply any additional fix?

Request to be included in [1.0.0](https://github.com/spf13/cobra/milestone/2). Ref #959.

> API changes are not on the roadmap for the 1.0.0. Bugs, cleanup, and documentation tasks are being targeted for 1.0.0. Agree. Precisely, I tried to be careful not to...

This PR is now rebased, to fix conflicts after #1048 was merged.

> @umarcor it seems you can merge your PR now @danmx, yes. This PR is ready to be merged since March 2019. I've been keeping it updated/rebased for 17 months....

> * `ValidArgs` will only be checked if `Args` is defined. This probably should be mentioned in the documentation when it mentions that `ValidArgs` is used to check positional args....

@marckhouzam I fixed the order of the validations, so that `ValidArgs` is checked regardless of `Args`. I also added tests for it. Thanks for catching that!

@mikeschinkel the status is the same as explained in https://github.com/spf13/cobra/issues/981#issuecomment-647784636.

A PR was created with the first three commits from this one: #1426. Then, this PR was cleaned up. Hope that helps move forward...