Unai Martinez-Corral
Unai Martinez-Corral
This is still WIP, but it depends on #841 being merged.
This PR is not stale, but blocked by #841. Please, remove the `kind/stale` label. See https://github.com/spf13/cobra/issues/1496#issuecomment-989131001 and https://github.com/spf13/cobra/issues/1496#issuecomment-989287359.
> IMO this PR overreaches a little over what was originally intended. Changing to Go modules is great but not required for this feature. This PR was based on #840...
@jharshman, I had the same point of view as you when I started to implement this. As I went forward and I saw the codebase, I concluded that the proposed...
> @umarcor thanks for taking the time to detail your approach and solution. Looks like one of the tests doesn't like the `go tool vet` command. > > ``` >...
#840 is merged now, so I rebased this on top of master. Since all the tests are passing, I believe it is ready for review, @eparis.
@jharshman, is it possible to have this merged or shall we wait until some other maintainer reviews it?