Unai Martinez-Corral
Unai Martinez-Corral
> Ok I will try to have a look this weekend. You have kept me busy discussion your other enhancements. It's ok. Nonetheless, this is not ready for merge. I'd...
> It seems you have reformatted many files making it harder to review. You can check the first 11 commits: https://github.com/VUnit/vunit/pull/470/files/b6bca4993ad78c66618767f76a60739372b3e086. That's before I switched to `integer_vector_ptr` and before I...
> The reason the `memory_t` uses one integer per byte is that is stores permission flags and expected value along with the data byte as a packed integer word. Then,...
> I'm not sure but @kraigher probably knows. It may have to do with memory performance/utilization. One large string vs many small fragmented strings. This is coherent with some comments...
@bradleyharden, did you do those changes on top of #507 or independent to them?
@bradleyharden, that sounds really good. I'm looking forward to read the PR!
The line it is complaining about (https://github.com/VUnit/vunit/blob/master/vunit/vhdl/data_types/src/integer_vector_ptr_pkg-body-2002p.vhd#L209) is the one used for every `set` of the internal integer vectors, which are used all over VUnit. I would expect such a...
@GlenNicholls, thanks! It seems that somewhere `set(ptr, 255, 1)` is being executed, but `ptr` was allocated with size 16. In this case, the id of `ptr` is 128. By searching...
@LarsAsplund, I see two main challenges in your proposal: - As you wrote in the update/edit, overriding the top-level generics of an entity when using a configuration as a primary...
@JimLewis: > The issue with ActiveHDL is not being able to run simulations within a given environment. It is to get the VHDL to write files in the expected locations...