Unai Martinez-Corral
Unai Martinez-Corral
I'd say it's an oversight. `tkeep` should be taken into account.
Apart from the copyright issues, I think that the acceptance tests are failing because the GHDL version being used at appveyor is v0.35. I could successfully execute them with `GHDL...
> It is possible to set a sim_option for just one test case or test bench so you do not have to set it for all test benches. Thanks. I'll...
Now, the elaboration flag `-Wl,` is only added to the testbench that uses the external memory/buffer. This produces an error during elaboration. I opened an issue about it: ghdl/ghdl#793. As...
@kraigher, I think this is ready for review now. As you see, I replaced the protected shared variables with a `memory_t`, which is similar to the one used in VUnit....
Hi @bradleyharden! Overall, I'm good with improving the structure to make it easier to understand and, hopefully, more efficient. However, I am afraid that your current proposal does not preserve...
> In the existing code, the `id` parameter in `extacc` mode is only ever used to index into the `st.eptrs` array. The element of `st.eptrs` is the pointer you get...
> Also, thanks for taking the time to explain this all to me. It's very relevant to my additions, so I want to make sure `string_ptr` is stable before I...
I'm the one who is sorry now. I completely overlooked your last comment. > Instead, I would like to see VUnit manage pointers for the user. We already do this...
@std-max, I'm not sure it's the same issue. @qarlosalberto do you mind trying with a recent version of GHDL?