svelte-lexical icon indicating copy to clipboard operation
svelte-lexical copied to clipboard

Modal elements class conflict with DaisyUI library

Open ktecho opened this issue 6 months ago • 13 comments

When trying to use the library and the demos, I found that in InsertImageDialog, the class "modal" of the modal was being taken by DaisyUI's "modal" class (see https://daisyui.com/components/modal/). That file was in the demo directory, so when I copied that to my code, I removed the "modal" class that was not being used, and it worked.

But then it seems that InsertImageUriDialogBody.svelte and InsertImageUriDialogBody.svelte in packages/svelte-lexical/src/components/toolbar/dialogs are also using this "modal" class. Those files are not in a demo, but in the library itself, so I would need to fork it to change it.

Would you rename the class from those modals, since it's not being used in the .css files, but only in the section that is as follows?

<style>
  .modal {
    width: 15em;
  }
</style>

Maybe it could be renamed, so it has a more specific name, the same as you did with Modal__title, Modal__content or Button__root.

ktecho avatar Jan 20 '24 22:01 ktecho