404 on login

[kieppie]

when logging in to http://umap.openstreetmap.fr/en/, get a 404 when logging via GitHub ID

[yohanboniface]

Try with https://umap.openstreetmap.fr/en/.

[kieppie]

nope. redirects to:

http://umap.openstreetmap.fr/complete/?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch&state=$SOMEHASH

[stevage]

Still broken for me.

[yohanboniface]

Still working for me ;)

I'll need more details to be able to help. Also check out your browser extensions.

[stevage]

Ah, that's interesting. In Chrome incognito mode (disables most extensions) it worked. So yeah, presumably one of my extensions is doing...something.

[stevage]

Huh, actually no. Disabling all my extensions didn't work. But if I log out of Github, then uMap's Github login page works (it shows the login screen and I can log in), but as soon as the login completes, it goes to the 404 page. (Same in incognito mode).

What other info would help debug this?

In Firefox, it works for me. Chrome 60.0.3112.113

[yohanboniface]

I don't have Chrome, but it works with Chromium 61.0.3163.79 (Developer Build) (64-bit) here (and Firefox, my usual browser).

Can you paste the final 404 URL?

[stevage]

https://umap.openstreetmap.fr/complete/?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch&state=0ZoEOHoz8lkcqMXSbn1G8PB7YhOXeZmm

[yohanboniface]

Can you log out from Github, click on Github icon on uMap, and copy-paste the URL you ends with on Github (before filling any form)?

[stevage]

https://github.com/login?client_id=c976781d7d009804978f&return_to=%2Flogin%2Foauth%2Fauthorize%3Fclient_id%3Dc976781d7d009804978f%26redirect_uri%3Dhttps%253A%252F%252Fumap.openstreetmap.fr%252Fcomplete%252Fgithub%252F%253Fredirect_state%253D0ZoEOHoz8lkcqMXSbn1G8PB7YhOXeZmm%26response_type%3Dcode%26scope%3Duser%253Aemail%26state%3D0ZoEOHoz8lkcqMXSbn1G8PB7YhOXeZmm

That's kind of interesting, because URL decoded it turns into:

https://github.com/login?client_id=c976781d7d009804978f&return_to=/login/oauth/authorize?client_id=c976781d7d009804978f&redirect_uri=https%3A%2F%2Fumap.openstreetmap.fr%2Fcomplete%2Fgithub%2F%3Fredirect_state%3D0ZoEOHoz8lkcqMXSbn1G8PB7YhOXeZmm&response_type=code&scope=user%3Aemail&state=0ZoEOHoz8lkcqMXSbn1G8PB7YhOXeZmm

and if that is decoded, it turns into:

https://github.com/login?client_id=c976781d7d009804978f&return_to=/login/oauth/authorize?client_id=c976781d7d009804978f&redirect_uri=https://umap.openstreetmap.fr/complete/github/?redirect_state=0ZoEOHoz8lkcqMXSbn1G8PB7YhOXeZmm&response_type=code&scope=user:email&state=0ZoEOHoz8lkcqMXSbn1G8PB7YhOXeZmm

I don't know if double URL encoding is intentional.

The final umap redirect page is thus:

https://umap.openstreetmap.fr/complete/?code=07ae8101f1a4d6d6811d

which is thus where the 404 comes from.

[yohanboniface]

Yes, double encoding is expected: it's a URL passed as parameter.

Sounds like the usual http/https story. Sadly it's not easy to force https on umap, because this will prevent user to use non https URLs for icons or remote data or import data, which is not very friendly, given the scope of uMap which is something like "make map easy for non technical people".

So try with http:// instead of https://, and if it does not work, it may be that Chrome is forcing you to use https, which is for good, but it's not always good.

[spectras]

Hit with the same issue. I can confirm this is due to http/https mismatch.

• Clicking the github link from https://umap.openstreetmap.fr/en/ gives a 404 (with the URL mismatch message in the url)
• Clicking the github link from http://umap.openstreetmap.fr/en/ works.

In both cases I was already logged in on github. So as a workaround, loading the http page helps. And login is still secure since it redirects to https right away.

Running Chromium 59.0.3071.109, though I doubt that's related.

[akien-mga]

For the reference, I can confirm that the issue is still valid today when using the GitHub identification. (Firefox Nightly, with DuckDuckGo Privacy Essentials which enforces HTTPS when available). Disabling the extension and going to the HTTP variant allows to log in.

[jpiesing]

It's still the case today - having found this issue, I manually edited the URL to change https to http and login worked.

[yohanboniface]

We switched Github to https now.

[FFMbyBicycle]

Thanks!

Sadly I cannot login for some weeks now, regardless of using http or https :cry: I can reproduce it every time using a standard Chromium 114 (Arch Linux) in private browsing mode and multiple Firefox instances with and without add-ons:

https://github.com/umap-project/umap/assets/74880272/1224ac9c-bcb2-4b23-87f6-2b36932be046

Using http instead of https results in the common 404 error, which should be fine due to the latest changes. I would like to backup all my maps and re-import them using another auth method, but I will have to login at least once for this...:smile: Revoking and granting access to my Github account didn't change anything, same error.

[yohanboniface]

That's another error, I guess due to username conflict (see for example #1106 ). What's your github username ?

[FFMbyBicycle]

Ah, okay. My Github user is FFMbyBicycle, thanks for checking!

[yohanboniface]

That username was used with your Twitter login. I've renamed it, so you can use Github now.

[FFMbyBicycle]

Whoops, thanks a lot! That Twitter hustle did cause some confusion, sorry for that.