umami icon indicating copy to clipboard operation
umami copied to clipboard

fix: Align region naming with ISO 3166-1 standard definition

Open 0x6768 opened this issue 2 months ago • 4 comments

fix: Align region naming with ISO 3166-1 standard definition

Summary

Updates geographical naming to comply with ISO 3166-1:2020 standard, specifically using the official English short name "Taiwan (Province of China)".

Technical Rationale

Standards Compliance

  • [x] ISO 3166-1:2020: Official standard for country and region codes
  • [x] Alpha-2 Code: TW
  • [x] English Short Name: Taiwan (Province of China)
  • [x] Full Compliance: Aligns with international coding standards

Identified Inconsistency

Current localization files use variations that deviate from the ISO 3166-1 standardized naming convention.

Standards-Based Solution

Apply the exact ISO 3166-1 defined nomenclature:

  • [x] English: Taiwan (Province of China)
  • [x] Language-specific translations maintain the standardized structure

Changes Made

Scope

  • [x] 50+ locale files updated to ISO 3166-1 compliance
  • [x] All geographical references standardized
  • [x] JSON structure and functionality preserved

Technical Implementation

  • [x] Automated script with ISO standard validation
  • [x] Each translation maintains ISO-defined structure

Verification

  • [x] ISO 3166-1:2020 standard compliance
  • [x] JSON syntax validation
  • [x] No API or functional changes
  • [x] Full rollback capability

Reference

ISO 3166-1:2020 "Codes for the representation of names of countries and their subdivisions"

0x6768 avatar Nov 02 '25 10:11 0x6768

@0x6768 is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 02 '25 10:11 vercel[bot]

This is the technical specification of the ISO 3166-1 international standard, just like we follow other ISO standards. As an open-source project, it follows international technical standards to ensure data interoperability and professionalism.

图片

Link: https://www.iso.org/obp/ui#iso:code:3166:TW

0x6768 avatar Nov 02 '25 11:11 0x6768

This is the second politically motivated PR to remove use of "Taiwan" and mark it as a province of the People's Republic of China. The other with similar changes is here: https://github.com/umami-software/umami/pull/3622

Additionally, it may simply be a bot or heavily relying on AI as many of the suggested changes seem incorrect, ie: From "SH": "Sf\u00e2nta Elena", to "SH": "Sfânta Elena"

ddxv avatar Nov 02 '25 13:11 ddxv

The ISO specification is incorrect. Deviation from it by correctly naming the obviously sovereign nation of Taiwan, Taiwan, is acceptable and necessary, as is maintaining the correct flag.

Furthermore, since Taiwan maintains the historically accurate Chinese character system, changing the name from 台灣 to the locally incomprehensible 中国台湾 would be incorrect.

komali2 avatar Nov 10 '25 05:11 komali2