umami icon indicating copy to clipboard operation
umami copied to clipboard

feat: add 28 days filter option

Open Kilian opened this issue 1 year ago • 5 comments

This fixes issue #3063

The 28 day view is, I think, important enough to make easily accessible.

Kilian avatar Dec 09 '24 09:12 Kilian

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:29am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
umami-analytics-us ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:29am
umami-mysql ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:29am
umami-postgresql ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:29am

vercel[bot] avatar Dec 09 '24 09:12 vercel[bot]

@Kilian is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 09 '24 09:12 vercel[bot]

I'm interested in this as well. Tracking multiple of weeks makes much more sense than 30 or 90 days in my opinion.

Any info whether this PR will be accepted?

schlagmichdoch avatar Nov 23 '25 17:11 schlagmichdoch

it's such a simple but clearly useful addition that I don't really understand why it's been ignored for almost a year :shrug:

Kilian avatar Nov 24 '25 16:11 Kilian

I understand the danger of cluttering the UI with too many options by adding everything that’s possible.

Probably, this is rather a decision whether to ditch the 30 days view in favor of the 28 days view or implement some setting or config to set the dropdown to specific datetime ranges.

I would prefer the latter: let admins specify the dropdown list that is presented in the UI:

SELECTABLE_DATE_RANGES='{["today","24h"],["this week","7d"],["this month","4w","12w"],["this year","6M","12M"]}'

"today", "this week", "this month", and "this year" are predefined keywords while the rest is parsed as datetime ranges defining the length of the datetimeframe + the unit in which it should be shown (4w -> show 4 bars for each week, 28d -> show 28 bars for each day).

If it seems too confusing that the config date ranges "4w" and "28d" mean something different, the single entries could also have two options: "length" and "unit".

schlagmichdoch avatar Nov 24 '25 21:11 schlagmichdoch